Add back the check for hierarchical post types, instead of just relying on page-attributes
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing on page-attributes. Add that information back to our readmes. This in essence reverts the changes done in #103
There was a problem hiding this comment.
LGTM and tests well.
Is it worth changing the How can I exclude certain custom post types? section of the readme to:
How can I modify sortable post types?
Post types can be included or excluded by using the simple_page_ordering_is_sortable filter.
For example, to exclude the excluded_post_type custom post type, add the following snippet in the theme function file or custom plugin:
add_filter( 'simple_page_ordering_is_sortable', function( $sortable, $post_type ) {
if ( 'excluded_post_type' === $post_type ) {
return false;
}
return $sortable;
}, 10, 2 );
To include the include_post_type custom post type, add the following snippet in the theme function file or custom plugin:
add_filter( 'simple_page_ordering_is_sortable', function( $sortable, $post_type ) {
if ( 'include_post_type' === $post_type ) {
return true;
}
return $sortable;
}, 10, 2 );
Co-authored-by: Peter Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In #103, we changed our sortable check to only rely on if a post type supports
page-attributes. This broke sorting for sites that use post types that are hierarchical but don't have that attribute set. While it may better align with how core is set up to only look atpage-attributes, it seems best to revert that change so we're not breaking functionality on sites that rely on the old behavior.This isn't a complete revert of the changes introduced in #103 but does bring back the missing functionality.
How to test the Change
page-attributessetpage-attributesset but is set as hierarchicalChangelog Entry
Credits
Props @dkotter
Checklist: